feat: allow for specifying a custom width for the profile popup #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Have you talked to Josh about this solution? If I understand correctly, he'll have to set this on every single customer site? |
|
Follow up question, can we set a sane default that can be overridden if necessary? |
|
@redreceipt I have not, I can reach out to him. He should only have to set this in places where the current pop-up doesn't fit, so it will depend on the specific use cases. Regarding a default to override, I think that's what we have in this PR. The existing behavior would be the default, and setting this new |
|
Got it! Ok we'll merge this and I'll make sure he knows to set this variable if he needs it. |
redreceipt
approved these changes
Nov 26, 2024
redreceipt
deleted the
apo-1017-seacoast-web-alignment-on-search-pop-out-is-off
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Issue
Closes #233
The profile popup width is based on the viewport width by default, and is absolutely positioned so its width isn't controlled by its container.
✏️ Solution
Implement a new data prop
data-search-profile-sizewhich takes a CSS width string, allowing the consumer to specify whatever width they need.Also nudge the popup to the right 15px to align it with the search bar.
🔬 To Test
I haven't been able to reproduce this locally, only was able to test by directly editing the source in the browser to apply the styling changes.
📸 Screenshots
With
data-search-profile-sizeset to365px: